Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include macOS in BraveP3AJSONOtherDeprecation, include iOS in BraveP3ATypicalJSONDeprecationEnabled #1263

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Include macOS in BraveP3AJSONOtherDeprecation, include iOS in BraveP3ATypicalJSONDeprecationEnabled #1263

merged 1 commit into from
Nov 19, 2024
+2 −0

Conversation

DJAndries
Copy link
Collaborator

No description provided.

@DJAndries DJAndries requested a review from a team as a code owner November 19, 2024 06:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1263.
    Android: Set the command line to --variations-pr=1263 in debug menu, restart the browser.
    iOS: Set Variations PR to 1263 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1263@bc878810e76b0aab72a75213978a53bbe25137f2
Uploaded Tue, 19 Nov 2024 06:32:41 GMT
PR commit 170e142
Base commit 6b924cc
Merge commit bc87881
Serial number 57ed40e84e9549fa07284762ccb21086

@DJAndries DJAndries force-pushed the deprec-p3a-json-macos branch from 371a47a to 170e142 Compare November 19, 2024 06:31
kjozwiak
kjozwiak approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 6444561 Nov 19, 2024
7 checks passed
@kjozwiak kjozwiak deleted the deprec-p3a-json-macos branch November 19, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJAndries @kjozwiak