-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new UndecryptablePasswords
study
#1165
Conversation
✅ Test Seed Generated SuccessfullyTo apply the test seed:
Seed Details
|
UndecryptablePasswords
studyUndecryptablePasswords
study [staging]
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password, login" and so security team members have been added as reviewers to take a look. |
UndecryptablePasswords
study [staging]UndecryptablePasswords
study
Enables the `SkipUndecryptablePasswords` feature to help users who are not able to see their logins in brave://password-manager/passwords Fixes #1164 Main issue tracked with brave/brave-browser#33548
026032c
to
a7e0f9a
Compare
Looks like we pushed out the above without verifying the actual study. Looks like @LaurenWags checked brave/brave-core#25040 via brave/brave-core#25040 (comment) & brave/brave-core#25040 (comment) so we at least didn't merge/push into |
Just for clarification - we've been using the work-around (via CLI; but exact same code) internally since 127 launched. Folks helping on Community have been recommending the same one since then too - we've had a ton of Community threads and Reddit posts.
Chrome has been live with the exact same feature since Jul 25 (although they did enabled the |
Enables the
SkipUndecryptablePasswords
feature to help users who are not able to see their logins in brave://password-manager/passwordsFixes #1164
Main issue tracked with brave/brave-browser#33548