Sync seed.json from production (42ce3f2583ee8f97bb76e99c332d960c643c7c2f) #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atuchin-m
reviewed
Apr 26, 2024
| @@ -500,7 +506,7 @@ | |||
| { | |||
| "feature_association": { | |||
| "enable_feature": [ | |||
| "HangWatcher" | |||
| "EnableHangWatcher" | |||
There was a problem hiding this comment.
Thanks for fixing this.
EnableHangWatcher is the correct feature name.
Somehow HangWatcher was used in main by mistake.
atuchin-m
reviewed
Apr 26, 2024
| ] | ||
| }, | ||
| "name": "BraveTranslateStudy" |
There was a problem hiding this comment.
I've checked that both translate-related features BraveTranslateStudy and BraveTranslateStudy are same before/after the PR. The only things is changed here is the order.
BTW, both features are outdated and limited by max_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy
seed.jsonfrom commit 42ce3f2This is to sync-up the current state of the branches and continue migration to per-file structure in
mainbranch.Related brave/brave-browser#33654