Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run WhatsNewStudy for 1.65.x [staging] #1001

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

simonhong
Copy link
Member

No description provided.

@simonhong simonhong self-assigned this Apr 16, 2024
@simonhong simonhong requested a review from a team as a code owner April 16, 2024 00:25
@simonhong simonhong changed the title Run WhatsNewStudy for 1.65.x Run WhatsNewStudy for 1.65.x [staging] Apr 16, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Getting the above merged so we can verify via main (staging) before merging #1002 once 1.65.x is released.

@kjozwiak kjozwiak merged commit 484c9a4 into main Apr 16, 2024
6 checks passed
@kjozwiak kjozwiak deleted the run_whats_new_for_1.65 branch April 16, 2024 05:15
@kjozwiak
Copy link
Member

kjozwiak commented Apr 17, 2024

Win 11 x64 verification(s)

1.63.174 Chromium: 122.0.6261.128 --> 1.65.114 Chromium: 124.0.6367.60

  • install/launch 1.63.174 Chromium: 122.0.6261.128 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and notice there's no variations/studies being listed under brave://version
  • restart Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensure that there's several studies being listed under Active variations via brave://version
  • uninstall 1.63.174 Chromium: 122.0.6261.128 (don't remove the current profile)
  • renamed AppData\Local\BraveSoftware\Brave-Browser --> AppData\Local\BraveSoftware\Brave-Browser-test
    • this is done due to Brave launching automatically after install but we want to re-launch using --variations-server-url=https://variations.bravesoftware.com/seed
  • install 1.65.114 Chromium: 124.0.6367.60 and close Brave once it's launched automatically
  • remove AppData\Local\BraveSoftware\Brave-Browser and replace it with AppData\Local\BraveSoftware\Brave-Browser-test
    • rename AppData\Local\BraveSoftware\Brave-Browser-test -> AppData\Local\BraveSoftware\Brave-Browser
  • re-launch 1.65.114 Chromium: 124.0.6367.60 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
Example Example Example
image image image

1.64.122 Chromium: 123.0.6312.122 --> 1.65.114 Chromium: 124.0.6367.60

  • install/launch 1.64.122 Chromium: 123.0.6312.122 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and notice there's no variations/studies being listed under brave://version
  • restart Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensure that there's several studies being listed under Active variations via brave://version
  • uninstall 1.64.122 Chromium: 123.0.6312.122 (don't remove the current profile)
  • renamed AppData\Local\BraveSoftware\Brave-Browser --> AppData\Local\BraveSoftware\Brave-Browser-test
    • this is done due to Brave launching automatically after install but we want to re-launch using --variations-server-url=https://variations.bravesoftware.com/seed
  • install 1.65.114 Chromium: 124.0.6367.60 and close Brave once it's launched automatically
  • remove AppData\Local\BraveSoftware\Brave-Browser and replace it with AppData\Local\BraveSoftware\Brave-Browser-test
    • rename AppData\Local\BraveSoftware\Brave-Browser-test -> AppData\Local\BraveSoftware\Brave-Browser
  • re-launch 1.65.114 Chromium: 124.0.6367.60 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
Example Example Example
image image image

installing 1.64.122 Chromium: 123.0.6312.122 (no upgrades)

Basically ensuring that the Whats New page isn't being displayed when installing 1.64.122 Chromium: 123.0.6312.122

  • launch 1.64.122 Chromium: 123.0.6312.122 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restart Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensure that you see studies being listed under Active variations: via brave://version
  • ensure that there's no Whats New page being opened/displayed

image

Ubuntu 22.04 x64 verification(s)

1.64.122 Chromium: 123.0.6312.122 --> 1.65.114 Chromium: 124.0.6367.60

  • installed 1.64.122 Chromium: 123.0.6312.122 using sudo dpkg -i ~/Downloads/brave-browser_1.64.122_amd64.deb
  • launched 1.64.122 Chromium: 123.0.6312.122 using brave-browser --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and notice there's no variations/studies being listed under brave://version
  • restart/re-launch using 1.64.122 Chromium: 123.0.6312.122 using brave-browser --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • uninstall 1.64.122 Chromium: 123.0.6312.122 using sudo dpkg -r brave-browser
  • install 1.65.114 Chromium: 124.0.6367.60 using sudo dpkg -i ~/Downloads/brave-browser_1.65.114_amd64.deb
  • launch Brave using brave-browser --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
Example Example Example
image image image

installing 1.64.122 Chromium: 123.0.6312.122 (no upgrades)

Basically ensuring that the Whats New page isn't being displayed when installing 1.64.122 Chromium: 123.0.6312.122

  • launch 1.64.122 Chromium: 123.0.6312.122 using brave-browser --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restart/re-launch Brave using brave-browser --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensure that you see studies being listed under Active variations: via brave://version
  • ensure that there's no Whats New page being opened/displayed

image

macOS x64 verification(s)

1.64.122 Chromium: 123.0.6312.122 --> 1.65.114 Chromium: 124.0.6367.60

  • install & launch 1.64.122 Chromium: 123.0.6312.122 using /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed and notice there's no variations/studies being listed under brave://version
  • restart/re-launch Brave using /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensure that there's several studies being listed under Active variations via brave://version
  • uninstall 1.63.174 Chromium: 122.0.6261.128
  • install 1.65.114 Chromium: 124.0.6367.60 and launch using /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
Example Example Example
Screenshot 2024-04-16 at 11 12 23 PM Screenshot 2024-04-16 at 11 15 06 PM Screenshot 2024-04-16 at 11 15 15 PM

installing 1.64.122 Chromium: 123.0.6312.122 (no upgrades)

Basically ensuring that the Whats New page isn't being displayed when installing 1.64.122 Chromium: 123.0.6312.122

  • install & launch 1.64.122 Chromium: 123.0.6312.122 using /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restart/re-launch Brave using /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --args --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensure that you see studies being listed under Active variations: via brave://version
  • ensure that there's no Whats New page being opened/displayed

Screenshot 2024-04-16 at 11 22 07 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants