Support search inside exp params (#892)

brave · Jan 25, 2024 · 315c2ad · 315c2ad
1 parent 2e938ec
commit 315c2ad
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/core/study_processor.ts b/src/core/study_processor.ts
@@ -69,7 +69,13 @@ export class StudyFilter {
     if (regex !== undefined) {
       let found = false;
       found ||= regex.test(s.study.name);
-      for (const e of s.study.experiment ?? []) found ||= regex.test(e.name);
+      for (const e of s.study.experiment ?? []) {
+        found ||= regex.test(e.name);
+        for (const p of e.param ?? []) {
+          if (p.name != null) found ||= regex.test(p.name);
+          if (p.value != null) found ||= regex.test(p.value);
+        }
+      }
       for (const feature of s.affectedFeatures) found ||= regex.test(feature);
       if (!found) return false;
     }

diff --git a/src/web/app/study_model.test.ts b/src/web/app/study_model.test.ts
@@ -34,6 +34,7 @@ describe('models', () => {
           enable_feature: ['EnabledFeature1', 'EnabledFeature2'],
           disable_feature: ['DisabledFeature'],
         },
+        param: [{ name: 'OsBlocklist', value: 'MacOs' }],
       },
       {
         name: 'Empty',
@@ -130,6 +131,8 @@ describe('models', () => {
     expect(useFilter(studyList, { search: 'DisabledFeature' }).length).toBe(1);
     expect(useFilter(studyList, { search: 'EnabledFeature1' }).length).toBe(1);
     expect(useFilter(studyList, { search: 'Default' }).length).toBe(1);
+    expect(useFilter(studyList, { search: 'OsBlock' }).length).toBe(1);
+    expect(useFilter(studyList, { search: 'Mac' }).length).toBe(1);
   });
 
   test('filter-outdated', () => {