Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Omaha 4 to 132.1.76.11 #27226

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Bump Omaha 4 to 132.1.76.11 #27226

merged 1 commit into from
Jan 14, 2025

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented Jan 14, 2025

This in particular switches the update client to universal binaries. I checked x64 and arm64 test release builds with this change and they worked fine.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A: I don't think it's worth testing updates with Omaha 4 after this PR, as we are still on Sparkle in production.

This in particular switches the update client to universal binaries.
@mherrmann mherrmann added dependencies Pull requests that update a dependency file release-notes/exclude QA/No CI/run-macos-x64 Run CI builds for macOS x64 labels Jan 14, 2025
@mherrmann mherrmann self-assigned this Jan 14, 2025
@mherrmann mherrmann requested a review from a team as a code owner January 14, 2025 13:17
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 14, 2025
@mherrmann mherrmann enabled auto-merge (squash) January 14, 2025 13:25
@mherrmann mherrmann merged commit 6e696fc into master Jan 14, 2025
20 of 21 checks passed
@mherrmann mherrmann deleted the bump-omaha4-to-132.1.76.11 branch January 14, 2025 15:07
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 14, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-macos-x64 Run CI builds for macOS x64 dependencies Pull requests that update a dependency file QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants