Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rewards ac android #27163

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Remove rewards ac android #27163

merged 2 commits into from
Jan 10, 2025

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jan 8, 2025

Resolves brave/brave-browser#42414

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added this to the 1.76.x - Nightly milestone Jan 8, 2025
@deeppandya deeppandya self-assigned this Jan 8, 2025
@deeppandya deeppandya requested review from a team as code owners January 8, 2025 21:10
Copy link
Collaborator

@zenparsing zenparsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewards cpp 👍

@deeppandya deeppandya requested a review from samartnik January 9, 2025 20:54
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya force-pushed the remove_rewards_ac_android branch from a3e66bb to 4262133 Compare January 9, 2025 21:53
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String reviewers ++

@deeppandya deeppandya merged commit a42a12a into master Jan 10, 2025
18 checks passed
@deeppandya deeppandya deleted the remove_rewards_ac_android branch January 10, 2025 01:18
@brave-builds
Copy link
Collaborator

Released in v1.76.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AC-related code on Android
5 participants