[iOS] Remove tab storage on all tab content scripts

[kylehickinson]

This change prepares for using the Chromium web embedder by removing weak storage of Tab objects passed in when creating classes confomring to TabContentScript which better matches JavaScriptFeature and its requirements.

This doesn't change how any underlying JavaScript functions or logic of the message handlers

Resolves brave/brave-browser#43184

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[kylehickinson]

This was never set so I removed it

[github-actions]

[puLL-Merge] - brave/brave-core@27162

Description

This PR significantly refactors the TabContentScript protocol and its implementations. The main changes involve removing the tab property from individual script handlers and instead passing the Tab instance as a parameter to the receivedScriptMessage method. This change promotes better encapsulation and reduces tight coupling between the script handlers and the Tab class.

Possible Issues

1. The refactoring might introduce subtle bugs if any script handlers were relying on maintaining state between messages using the tab property.
2. Some script handlers may need additional refactoring to handle the new method signature correctly.

Security Hotspots

No significant security issues are introduced by this change. However, careful testing should be done to ensure that all script handlers are correctly handling the new method signature, especially in security-sensitive areas like the wallet and authentication handlers.

Changes

Changes

1. TabContentScript.swift:

   • Updated the userContentController method to tab(_:receivedScriptMessage:replyHandler:).
   • Removed the tab property from the protocol.

2. Various script handlers (e.g., BlockedDomainScriptHandler, HTTPBlockedScriptHandler, etc.):

   • Removed tab property.
   • Updated method signature to match the new protocol.
   • Refactored internal methods to accept tab as a parameter where necessary.

3. Tab.swift:

   • Updated TabContentScriptManager to pass the Tab instance to script handlers.

4. BrowserViewController.swift:

   • Updated script handler initializations to remove tab parameter where it's no longer needed.

5. Test files:

   • Updated to reflect the new method signatures and initialization patterns.

sequenceDiagram
    participant BVC as BrowserViewController
    participant Tab
    participant TSM as TabScriptManager
    participant SH as ScriptHandler

    BVC->>Tab: Creates Tab
    Tab->>TSM: Creates TabScriptManager
    BVC->>Tab: Adds ScriptHandlers
    Tab->>TSM: Registers ScriptHandlers
    Note over Tab,TSM: ScriptHandlers no longer hold reference to Tab
    WKWebView->>TSM: Receives script message
    TSM->>SH: Calls tab(_:receivedScriptMessage:replyHandler:)
    SH->>Tab: Interacts with Tab as needed
    SH->>TSM: Returns result
    TSM->>WKWebView: Sends reply

Loading