Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SaveImageMultipleTimes browser test on x64 (uplift to 1.73.x) #27154

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "base/threading/thread_restrictions.h"
#include "brave/browser/ntp_background/constants.h"
#include "brave/components/constants/brave_paths.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
Expand Down Expand Up @@ -111,8 +112,16 @@ IN_PROC_BROWSER_TEST_F(CustomBackgroundFileManagerBrowserTest,
EXPECT_TRUE(base::PathExists(test_file()));
}

// On Mac x64 CI node we presume this test crashes the whole suite.
// https://github.com/brave/brave-browser/issues/38988
#if BUILDFLAG(IS_MAC) && defined(ARCH_CPU_ARM_FAMILY)
#define MAYBE_SaveImageMultipleTimes SaveImageMultipleTimes
#else
#define MAYBE_SaveImageMultipleTimes DISABLED_SaveImageMultipleTimes
#endif

IN_PROC_BROWSER_TEST_F(CustomBackgroundFileManagerBrowserTest,
SaveImageMultipleTimes) {
MAYBE_SaveImageMultipleTimes) {
for (int i = 0; i < 3; i++) {
base::RunLoop run_loop;
base::FilePath expected_path =
Expand Down
Loading