Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Prompt Select Account when Sending from Portfolio #27146

Conversation

Douglashdaniel
Copy link
Contributor

Description

We will now prompt to select an Account when a user clicks Send for an asset on the Portfolio and their portfolio is not grouped by Accounts

Resolves brave/brave-browser#43131

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and navigate to the Portfolio screen
  2. Group your assets by None or Networks
  3. Click the More Menu for an asset and click Send
  4. It should navigate to the Send screen and prompt you to select an Account to send from.
  5. If you close the Select Account modal, params will be cleared and nothing will be selected.
  6. If you click Back on the Select Account modal, params will be cleared and you can make a new selection.
  7. If you have your Portfolio grouped by Accounts and you click send for an asset, the associated account will be automatically selected on the Send screen
Screen.Recording.7.mov

@Douglashdaniel Douglashdaniel self-assigned this Jan 7, 2025
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner January 7, 2025 19:56
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jan 7, 2025
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Douglashdaniel Douglashdaniel merged commit d14ca67 into master Jan 8, 2025
19 checks passed
@Douglashdaniel Douglashdaniel deleted the feat-wallet-prompt-select-account-when-sending-from-portfolio branch January 8, 2025 05:48
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Jan 8, 2025
@brave-builds
Copy link
Collaborator

Released in v1.75.154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt Select Account when clicking Send from Portfolio
3 participants