Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Fix authentication popup showing the realm #27114

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Jan 3, 2025

Summary

  • Remove realm from auth popup
  • Show full origin in the auth popup.
  • Port is always shown.

Resolves brave/brave-browser#43072

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Jan 3, 2025
@Brandon-T Brandon-T self-assigned this Jan 3, 2025
@Brandon-T Brandon-T requested a review from a team as a code owner January 3, 2025 17:44
Copy link
Contributor

github-actions bot commented Jan 3, 2025

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "authentication" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

@nuo-xu
Copy link
Contributor

nuo-xu commented Jan 3, 2025

im seeing the port 443
Simulator Screenshot - iPhone 16 Pro Max - 2025-01-03 at 14 32 06

@Brandon-T
Copy link
Contributor Author

Brandon-T commented Jan 3, 2025

im seeing the port 443

Yeah correct. I changed it to always show in the second commit. Sorry I'll update the summary comment.

@Brandon-T Brandon-T merged commit cf007ac into master Jan 3, 2025
19 checks passed
@Brandon-T Brandon-T deleted the bugfix/AuthenticationRealmFix branch January 3, 2025 21:22
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Jan 3, 2025
@brave-builds
Copy link
Collaborator

Released in v1.75.147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove HTTP auth realm text and show full origin
6 participants