Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing resource dependencies to brave_*_tests. #27078

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Dec 20, 2024

Add resources as test deps. Without them we have these issues:

  1. A change in chromium resources does not trigger a rebuild of resource packs when running brave tests via npm test brave_browser_tests. This is required when working on upstream overrides.
  2. It's impossible to run brave_browser_tests without building brave first.

Things work on CI correctly, because we always build brave before building/running tests.

Resolves brave/brave-browser#43009

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov marked this pull request as ready for review December 20, 2024 14:28
@goodov goodov enabled auto-merge (squash) December 20, 2024 14:28
@goodov goodov requested review from emerick and mkarolin January 9, 2025 10:06
@goodov goodov merged commit 51162ed into master Jan 9, 2025
21 checks passed
@goodov goodov deleted the issues/43009 branch January 9, 2025 14:35
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 9, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing resource deps in test targets
3 participants