Fixed blank tab is shown after attaching split view #26994
Merged
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
fix_blank_tab_after_attaching_split_view
branch
from
80c3e3d to
5cba6b2
Compare
fallaciousreasoning
approved these changes
Dec 15, 2024
fix brave/brave-browser#41852 When split view transfers to another browser, its web contents should be cleared before attached to target browser. It's done by SplitView::UpdateContentsWebViewVisual(). So far, we posted it to next turn when we break tile. If we break a tile by unsplit, it doesn't cause any issue because any other secondary web view doesn't host that secondary web contents. However, if it's attached to another browser window, it's another story. When we detach a split view from browser A and attach to browser B, browser A breaks a tile after detached. And then, they are attached to browser B and we make them as a split view. If we don't clear secondary web contents after break the tile synchronously, browser A and browser B's secondary web view has same web contents till posed `UpdateContentsWebViewVisual(). This could cause unexpected behavior like above issue. So, secondary web view should be cleared synchronously after breaking a tile.
simonhong
force-pushed
the
fix_blank_tab_after_attaching_split_view
branch
from
5cba6b2 to
1932bad
Compare
|
Released in v1.75.154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#41852
When split view transfers to another browser,
its web contents should be cleared before attached to target browser.
It's done by SplitView::UpdateContentsWebViewVisual().
So far, we posted it to next turn when we break tile.
If we break a tile by unsplit, it doesn't cause any issue because
any other secondary web view doesn't host that secondary web contents.
However, if it's attached to another browser window, it's another story.
When we detach a split view from browser A and attach to browser B,
browser A breaks a tile after detached.
And then, they are attached to browser B and we make them as a split view.
If we don't clear secondary web contents after break the tile synchronously,
browser A and browser B's secondary web view has same web contents till posted
UpdateContentsWebViewVisual()executed.This could cause unexpected behavior like above issue.
So, secondary web view should be cleared synchronously after breaking a tile.
Screen.Recording.2024-12-12.143054.mp4
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
SplitViewBrowserTest.BreakingTileMakesSecondaryWebViewHidden
See the linked issue for manul test