Don't clear first party storage area if browser is launched in incognito mode from command line #24543

Ilie-Lesan · 2024-07-06T13:01:22Z

When opening the browser in incognito mode from command line, we should prevent deleting the origins marked with "Forget me when I close this site".

The reason for this is that the incognito window does not re-create the lifetime of TLD(TLDEphemeralLifetimeCreated never gets called because the default profile browser windows are not restored in incognito mode) from the main profile and as a result, they get scheduled for deletion.

Resolves brave/brave-browser#39107

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

goodov · 2024-07-10T05:19:37Z

Thank you! Having a browser test for this would be nice. Can you try to add one please?

You can use this test as a starting point, you might need to use PRE_ tests to open few websites first.

brave-core/browser/ephemeral_storage/ephemeral_storage_forget_by_default_browsertest.cc

Lines 178 to 215 in b4332ca

    
           IN_PROC_BROWSER_TEST_F(EphemeralStorageForgetByDefaultBrowserTest, 
        
                                  ForgetFirstPartyInheritedInIncognito) { 
        
             Browser* incognito_browser = CreateIncognitoBrowser(nullptr); 
        
             EXPECT_EQ( 
        
                 brave_shields::GetCookieControlType( 
        
                     HostContentSettingsMapFactory::GetForProfile( 
        
                         incognito_browser->profile()), 
        
                     CookieSettingsFactory::GetForProfile(incognito_browser->profile()) 
        
                         .get(), 
        
                     a_site_ephemeral_storage_url_), 
        
                 brave_shields::ControlType::BLOCK_THIRD_PARTY); 
        
             brave_shields::SetForgetFirstPartyStorageEnabled( 
        
                 content_settings(), true, a_site_ephemeral_storage_url_); 
        
             EXPECT_TRUE(brave_shields::GetForgetFirstPartyStorageEnabled( 
        
                 HostContentSettingsMapFactory::GetForProfile( 
        
                     incognito_browser->profile()), 
        
                 a_site_ephemeral_storage_url_)); 
        
             ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser, 
        
                                                      a_site_ephemeral_storage_url_)); 
        
             auto* incognito_web_contents = 
        
                 incognito_browser->tab_strip_model()->GetActiveWebContents(); 
        
             // We set a value in the page where all the frames are first-party. 
        
             SetAndCheckValuesInFrames(incognito_web_contents, "a.com", "from=a.com"); 
        
             // After keepalive values should be cleared. 
        
             ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser, 
        
                                                      b_site_ephemeral_storage_url_)); 
        
             WaitForCleanupAfterKeepAlive(incognito_browser); 
        
             ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser, 
        
                                                      a_site_ephemeral_storage_url_)); 
        
             ExpectValuesFromFramesAreEmpty(FROM_HERE, 
        
                                            GetValuesFromFrames(incognito_web_contents)); 
        
           }

goodov · 2024-07-10T05:20:27Z

components/ephemeral_storage/ephemeral_storage_service.cc

@@ -327,6 +327,13 @@ void EphemeralStorageService::ScheduleFirstPartyStorageAreasCleanupOnStartup() {

 void EphemeralStorageService::CleanupFirstPartyStorageAreasOnStartup() {
  DCHECK(!context_->IsOffTheRecord());
+
+  Profile* profile = Profile::FromBrowserContext(context_);
+  if (profile->HasAnyOffTheRecordProfile()) {


maybe the better approach here is to detect if any "normal" profile windows are opened or not.

Thanks for the suggestion, I will try to follow it.

Done. Please have a look

Ilie-Lesan · 2024-07-10T18:10:04Z

Thank you! Having a browser test for this would be nice. Can you try to add one please?

You can use this test as a starting point, you might need to use PRE_ tests to open few websites first.

brave-core/browser/ephemeral_storage/ephemeral_storage_forget_by_default_browsertest.cc

Lines 178 to 215 in b4332ca

IN_PROC_BROWSER_TEST_F(EphemeralStorageForgetByDefaultBrowserTest,

ForgetFirstPartyInheritedInIncognito) {

Browser* incognito_browser = CreateIncognitoBrowser(nullptr);

EXPECT_EQ(

brave_shields::GetCookieControlType(

HostContentSettingsMapFactory::GetForProfile(

incognito_browser->profile()),

CookieSettingsFactory::GetForProfile(incognito_browser->profile())

.get(),

a_site_ephemeral_storage_url_),

brave_shields::ControlType::BLOCK_THIRD_PARTY);

brave_shields::SetForgetFirstPartyStorageEnabled(

content_settings(), true, a_site_ephemeral_storage_url_);

EXPECT_TRUE(brave_shields::GetForgetFirstPartyStorageEnabled(

HostContentSettingsMapFactory::GetForProfile(

incognito_browser->profile()),

a_site_ephemeral_storage_url_));

ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser,

a_site_ephemeral_storage_url_));

auto* incognito_web_contents =

incognito_browser->tab_strip_model()->GetActiveWebContents();

// We set a value in the page where all the frames are first-party.

SetAndCheckValuesInFrames(incognito_web_contents, "a.com", "from=a.com");

// After keepalive values should be cleared.

ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser,

b_site_ephemeral_storage_url_));

WaitForCleanupAfterKeepAlive(incognito_browser);

ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser,

a_site_ephemeral_storage_url_));

ExpectValuesFromFramesAreEmpty(FROM_HERE,

GetValuesFromFrames(incognito_web_contents));

}

Yes, I will try to write a browsing test. Thanks!

Ilie-Lesan · 2024-07-13T14:06:40Z

Thank you! Having a browser test for this would be nice. Can you try to add one please?

You can use this test as a starting point, you might need to use PRE_ tests to open few websites first.

brave-core/browser/ephemeral_storage/ephemeral_storage_forget_by_default_browsertest.cc

Lines 178 to 215 in b4332ca

IN_PROC_BROWSER_TEST_F(EphemeralStorageForgetByDefaultBrowserTest,

ForgetFirstPartyInheritedInIncognito) {

Browser* incognito_browser = CreateIncognitoBrowser(nullptr);

EXPECT_EQ(

brave_shields::GetCookieControlType(

HostContentSettingsMapFactory::GetForProfile(

incognito_browser->profile()),

CookieSettingsFactory::GetForProfile(incognito_browser->profile())

.get(),

a_site_ephemeral_storage_url_),

brave_shields::ControlType::BLOCK_THIRD_PARTY);

brave_shields::SetForgetFirstPartyStorageEnabled(

content_settings(), true, a_site_ephemeral_storage_url_);

EXPECT_TRUE(brave_shields::GetForgetFirstPartyStorageEnabled(

HostContentSettingsMapFactory::GetForProfile(

incognito_browser->profile()),

a_site_ephemeral_storage_url_));

ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser,

a_site_ephemeral_storage_url_));

auto* incognito_web_contents =

incognito_browser->tab_strip_model()->GetActiveWebContents();

// We set a value in the page where all the frames are first-party.

SetAndCheckValuesInFrames(incognito_web_contents, "a.com", "from=a.com");

// After keepalive values should be cleared.

ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser,

b_site_ephemeral_storage_url_));

WaitForCleanupAfterKeepAlive(incognito_browser);

ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser,

a_site_ephemeral_storage_url_));

ExpectValuesFromFramesAreEmpty(FROM_HERE,

GetValuesFromFrames(incognito_web_contents));

}

@goodov Can you help me a bit with the testing? It looks like reproducing this scenario in the test is a bit hard.
I've tried multiple solutions but no one worked well. Can you have a look and tell me what I'm not doing right? Thanks!
https://gist.github.com/tech-zilla/0c58a249ae26c80cc296ce8fdf0f34a4

goodov · 2024-07-15T11:59:05Z

components/ephemeral_storage/ephemeral_storage_service.cc

@@ -327,6 +339,11 @@ void EphemeralStorageService::ScheduleFirstPartyStorageAreasCleanupOnStartup() {

 void EphemeralStorageService::CleanupFirstPartyStorageAreasOnStartup() {
  DCHECK(!context_->IsOffTheRecord());
+  Profile* profile = Profile::FromBrowserContext(context_);
+  if (!DoesProfileHaveAnyBrowserWindow(profile)) {


actually, now I'm thinking: shouldn't we instead start the cleanup process timer when a regular profile window is created (or exists) for context_?

right now if you open a normal window with an existing incognito window, the cleanup won't run.

From what I saw in the code, there are two situations that trigger the cleanup.

At startup, there is a 5-second keep-alive timer after which the cleanup is executed(so if you are quick enough to enter the URL in the address bar, the cleanup is aborted)

After closing a tab, there is a 30-second grace period (this option is enabled by default) after which all data cleanup is started.

Are you running in one of these situations? Can you please add some steps to reproduce? Thanks!

goodov · 2024-07-15T12:38:26Z

Can you help me a bit with the testing? It looks like reproducing this scenario in the test is a bit hard.
I've tried multiple solutions but no one worked well. Can you have a look and tell me what I'm not doing right? Thanks!

You need to create a separate test fixture with SetUpCommandLine override. If it's a non-PRE test, then you should add switches::kIncognito.

something like:

 void SetUpCommandLine(base::CommandLine* command_line) override {
    EphemeralStorageForgetByDefaultBrowserTest::SetUpCommandLine(command_line);
    std::string test_name =
        ::testing::UnitTest::GetInstance()->current_test_info()->name();
    const bool is_pre_test = test_name.starts_with("PRE_");
    if (!is_pre_test) {
      command_line->AppendSwitch(switches::kIncognito);
    }
  }

in non-PRE test you need to call WaitForCleanupAfterKeepAlive with a non-incognito profile and after that ensure that data (you can check cookies) is not removed there.

goodov · 2024-07-25T16:17:48Z

@tech-zilla

+ npm run presubmit
Running Python 3 presubmit upload checks ...
  checking for commit objects in tree took a long time: 0.5s
** Presubmit Warnings: 2 **
Found 1 lines longer than 80 characters (first 5 shown).
  browser/ephemeral_storage/ephemeral_storage_browsertest.cc, line 312, 84 chars
Found line ending with white spaces in:
***************
browser/ephemeral_storage/ephemeral_storage_forget_by_default_browsertest.cc:612
***************
** Presubmit ERRORS: 2 **
The brave directory requires source formatting. Please run: npm run presubmit -- --fix.
--- browser/ephemeral_storage/ephemeral_storage_browsertest.cc  (before formatting)
+++ browser/ephemeral_storage/ephemeral_storage_browsertest.cc  (after formatting)
@@ -309,7 +309,8 @@
   return content::EvalJs(host, "document.cookie");
 }
-size_t EphemeralStorageBrowserTest::WaitForCleanupAfterKeepAlive(Profile* profile) {
+size_t EphemeralStorageBrowserTest::WaitForCleanupAfterKeepAlive(
+    Profile* profile) {
   if (!profile) {
     profile = browser()->profile();
   }
@@ -322,8 +323,7 @@
   // failures when the timing is "just right". Do a no-op removal here to make
   // sure the queued Ephemeral Storage cleanup was complete.
   BrowsingDataRemoverObserver data_remover_observer;
-  content::BrowsingDataRemover* remover =
-      profile->GetBrowsingDataRemover();
+  content::BrowsingDataRemover* remover = profile->GetBrowsingDataRemover();
   remover->AddObserver(&data_remover_observer);
   remover->RemoveAndReply(base::Time(), base::Time::Max(), 0, 0,
                           &data_remover_observer);
You added one or more #includes that violate checkdeps rules.
  brave/components/ephemeral_storage/ephemeral_storage_service.cc
      Illegal include: "chrome/browser/profiles/profile.h"
    Because of "-chrome" from brave's include_rules.
  brave/components/ephemeral_storage/ephemeral_storage_service.cc
      Illegal include: "chrome/browser/ui/browser.h"
    Because of "-chrome" from brave's include_rules.
  brave/components/ephemeral_storage/ephemeral_storage_service.cc
      Illegal include: "chrome/browser/ui/browser_finder.h"
    Because of "-chrome" from brave's include_rules.
  brave/components/ephemeral_storage/ephemeral_storage_service.cc
      Illegal include: "chrome/browser/ui/browser_window.h"
    Because of "-chrome" from brave's include_rules.
Presubmit checks took 2.6s to calculate.
There were Python 3 presubmit errors.
null
Process exited with code 1

you need to move the added function into EphemeralStorageServiceDelegate and format things.

make sure to rebase before doing that.

goodov

very good job! thank you! Let's fix few things and I trigger CI.

goodov · 2024-07-29T05:27:04Z

browser/ephemeral_storage/brave_ephemeral_storage_service_delegate.cc

+      return;
+    }
+  }
+  is_window_visible = false;


just return a boolean from the function, I don't see why you need an optional returned as a mutable parameter here.

if you need to have a default implementation for the virtual function in .cc in this case (clang checks may ask for it), just add a .cc file and implement it, no big deal.

goodov · 2024-07-29T05:27:32Z

browser/ephemeral_storage/ephemeral_storage_forget_by_default_browsertest.cc

@@ -4,12 +4,12 @@
 * You can obtain one at https://mozilla.org/MPL/2.0/. */

 #include "brave/browser/ephemeral_storage/ephemeral_storage_browsertest.h"
-


please run npm run presubmit --fix locally before pushing things. I think the format checks won't like the removal of this line.

I'm still seeing some warnings after adding the space, that's why I didn't remove it

goodov · 2024-07-29T05:29:23Z

browser/ephemeral_storage/ephemeral_storage_forget_by_default_browsertest.cc

+    }
+  }
+
+  static bool IsPreTest() {


nit: I think this should be called IsPreTestToEnableIncognito, because you have 2 PRE_ tests, but you're actually interested in one of them.

Ilie-Lesan · 2024-07-29T12:53:27Z

thanks for the support during the code review!

goodov · 2024-10-31T07:16:26Z

@Ilie-Lesan

======= Failed test run #1 ==========
  FAILURE
  ------- Stdout: -------
  [ RUN      ] EphemeralStorageServiceForgetFirstPartyTest.CleanupOnRestart
  ../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:313: Failure
  Expected equality of these values:
    profile_.GetPrefs()->GetList(kFirstPartyStorageOriginsToCleanup).size()
      Which is: 1
    0u
      Which is: 0
  Stack trace:
  #0 0x5b4256d1a4ec ephemeral_storage::EphemeralStorageServiceForgetFirstPartyTest_CleanupOnRestart_Test::TestBody() [../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:311:5]
  ../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:309: Failure
  Actual function call count doesn't match EXPECT_CALL(*mock_delegate_, CleanupFirstPartyStorageArea(ephemeral_domain))...
           Expected: to be called once
             Actual: never called - unsatisfied and active
  Stack trace:
  #0 0x5b425e5e361b testing::internal::GoogleTestFailureReporter::ReportFailure() [../../third_party/googletest/src/googlemock/src/gmock-internal-utils.cc:108:47]
  #1 0x5b425e5e6dba testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() [../../third_party/googletest/src/googlemock/include/gmock/internal/gmock-internal-utils.h:259:27]
  #2 0x5b425e5e77e3 testing::Mock::VerifyAndClearExpectationsLocked() [../../third_party/googletest/src/googlemock/src/gmock-spec-builders.cc:655:17]
  #3 0x5b425e5e7681 testing::Mock::VerifyAndClearExpectations() [../../third_party/googletest/src/googlemock/src/gmock-spec-builders.cc:624:10]
  #4 0x5b4256d17e08 ephemeral_storage::(anonymous namespace)::ScopedVerifyAndClearExpectations::~ScopedVerifyAndClearExpectations() [../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:32:5]
  #5 0x5b4256d1a556 ephemeral_storage::EphemeralStorageServiceForgetFirstPartyTest_CleanupOnRestart_Test::TestBody() [../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:314:3]
  [  FAILED  ] EphemeralStorageServiceForgetFirstPartyTest.CleanupOnRestart (244 ms)
  [4509/7015] EphemeralStorageServiceForgetFirstPartyTest.CleanupOnRestart (244 ms)

Ilie-Lesan · 2024-11-30T16:18:34Z

@Ilie-Lesan

======= Failed test run #1 ==========
  FAILURE
  ------- Stdout: -------
  [ RUN      ] EphemeralStorageServiceForgetFirstPartyTest.CleanupOnRestart
  ../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:313: Failure
  Expected equality of these values:
    profile_.GetPrefs()->GetList(kFirstPartyStorageOriginsToCleanup).size()
      Which is: 1
    0u
      Which is: 0
  Stack trace:
  #0 0x5b4256d1a4ec ephemeral_storage::EphemeralStorageServiceForgetFirstPartyTest_CleanupOnRestart_Test::TestBody() [../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:311:5]
  ../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:309: Failure
  Actual function call count doesn't match EXPECT_CALL(*mock_delegate_, CleanupFirstPartyStorageArea(ephemeral_domain))...
           Expected: to be called once
             Actual: never called - unsatisfied and active
  Stack trace:
  #0 0x5b425e5e361b testing::internal::GoogleTestFailureReporter::ReportFailure() [../../third_party/googletest/src/googlemock/src/gmock-internal-utils.cc:108:47]
  #1 0x5b425e5e6dba testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() [../../third_party/googletest/src/googlemock/include/gmock/internal/gmock-internal-utils.h:259:27]
  #2 0x5b425e5e77e3 testing::Mock::VerifyAndClearExpectationsLocked() [../../third_party/googletest/src/googlemock/src/gmock-spec-builders.cc:655:17]
  #3 0x5b425e5e7681 testing::Mock::VerifyAndClearExpectations() [../../third_party/googletest/src/googlemock/src/gmock-spec-builders.cc:624:10]
  #4 0x5b4256d17e08 ephemeral_storage::(anonymous namespace)::ScopedVerifyAndClearExpectations::~ScopedVerifyAndClearExpectations() [../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:32:5]
  #5 0x5b4256d1a556 ephemeral_storage::EphemeralStorageServiceForgetFirstPartyTest_CleanupOnRestart_Test::TestBody() [../../brave/browser/ephemeral_storage/ephemeral_storage_service_unittest.cc:314:3]
  [  FAILED  ] EphemeralStorageServiceForgetFirstPartyTest.CleanupOnRestart (244 ms)
  [4509/7015] EphemeralStorageServiceForgetFirstPartyTest.CleanupOnRestart (244 ms)

@goodov Completely forgot about this PR. I will have a look next week

…ch (brave#26531) * Add Smart-Proxy Routing Toggle * Add VPN Kill-Switch Toggle * Upgrade to GuardianConnect 2.0.1

This introduces a closer degree of parity with other browsers by supporting the de-facto standard of using Ctrl+Shift+S to create a screenshot. Resolves brave/brave-browser#42682

Create & use a frozen copy of window.origin.

fix brave/brave-browser#42693 When sidebar menu is handled, it should check previous menu state. If prev entry is separator, it should be removed before sidebar menu because sidebar menu will add it's own top & bottom separators.

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `path-to-regexp` from 0.1.10 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `express` from 4.21.1 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.1...4.21.2) --- updated-dependencies: - dependency-name: path-to-regexp dependency-type: indirect - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

* Disabled cosmetic filters on speedreader pages.

… any browser window associated

Ilie-Lesan · 2025-01-02T18:05:35Z

Messed up the branch after wrong rebase

goodov reviewed Jul 10, 2024

View reviewed changes

goodov reviewed Jul 15, 2024

View reviewed changes

brave-builds mentioned this pull request Jul 25, 2024

CI run for contributor PR #24543 #24840

Closed

goodov reviewed Jul 29, 2024

View reviewed changes

brave-builds mentioned this pull request Oct 31, 2024

CI run for contributor PR #24543 #26313

Draft

Brandon-T and others added 17 commits January 2, 2025 19:20

[iOS] - Update Guardian Connect & Add Smart Proxy Setting & Kill Swit…

35a0d15

…ch (brave#26531) * Add Smart-Proxy Routing Toggle * Add VPN Kill-Switch Toggle * Upgrade to GuardianConnect 2.0.1

Resolve QSE google search query

e3b611f

sets default shortcut for screenshot via sharing hub (brave#26885)

1d1f125

This introduces a closer degree of parity with other browsers by supporting the de-facto standard of using Ctrl+Shift+S to create a screenshot. Resolves brave/brave-browser#42682

[ads] const std::string_view code health

1e78602

[ads] base::MakeFixedFlatSet code health

37403be

[ads] std::optional code health

25da4b8

[ads] IWYU code health

ced5821

[ads] Move constructor code health

0b571c1

[ads] Vertical whitespace code health

5d55612

[Web UI]: Convert Bookmarks to new overrides (brave#26880)

a6736dc

1.75.78

ffcf9ee

fix(privacy): Secure access to window origin on iOS (brave#26841)

846d68c

Create & use a frozen copy of window.origin.

Fixed empty space is added in guest window's app menu

517ccc1

fix brave/brave-browser#42693 When sidebar menu is handled, it should check previous menu state. If prev entry is separator, it should be removed before sidebar menu because sidebar menu will add it's own top & bottom separators.

1.75.79

1468c1c

[Web UI]: Convert extensions to new overrides (brave#26881)

21abe98

Disable cosmetic filtering on Speedreader pages (brave#25692)

675d171

* Disabled cosmetic filters on speedreader pages.

brave-builds and others added 2 commits January 2, 2025 19:21

1.75.140

a7a2cc9

Fix ephemeral storage service unit test when the profile doesn't have…

52ad91c

… any browser window associated

Ilie-Lesan requested review from bsclifton, a team, AlexeyBarabash, samartnik, SergeyZhukovsky, deeppandya, iefremov, simonhong and bridiver as code owners January 2, 2025 17:23

Ilie-Lesan closed this Jan 2, 2025

Ilie-Lesan mentioned this pull request Jan 3, 2025

Ignore cleanup cookies at startup for command line incognito mode #27111

Open

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't clear first party storage area if browser is launched in incognito mode from command line #24543

Don't clear first party storage area if browser is launched in incognito mode from command line #24543

Ilie-Lesan commented Jul 6, 2024

goodov commented Jul 10, 2024

goodov Jul 10, 2024

Ilie-Lesan Jul 10, 2024 •

edited

Loading

Ilie-Lesan Jul 13, 2024

Ilie-Lesan commented Jul 10, 2024

Ilie-Lesan commented Jul 13, 2024

goodov Jul 15, 2024

Ilie-Lesan Jul 15, 2024 •

edited

Loading

goodov commented Jul 15, 2024

goodov commented Jul 25, 2024

goodov left a comment

goodov Jul 29, 2024 •

edited

Loading

goodov Jul 29, 2024

Ilie-Lesan Jul 29, 2024

goodov Jul 29, 2024

Ilie-Lesan commented Jul 29, 2024

goodov commented Oct 31, 2024

Ilie-Lesan commented Nov 30, 2024

Ilie-Lesan commented Jan 2, 2025

		@@ -4,12 +4,12 @@
		* You can obtain one at https://mozilla.org/MPL/2.0/. */

		#include "brave/browser/ephemeral_storage/ephemeral_storage_browsertest.h"

Don't clear first party storage area if browser is launched in incognito mode from command line #24543

Don't clear first party storage area if browser is launched in incognito mode from command line #24543

Conversation

Ilie-Lesan commented Jul 6, 2024

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

goodov commented Jul 10, 2024

goodov Jul 10, 2024

Choose a reason for hiding this comment

Ilie-Lesan Jul 10, 2024 • edited Loading

Choose a reason for hiding this comment

Ilie-Lesan Jul 13, 2024

Choose a reason for hiding this comment

Ilie-Lesan commented Jul 10, 2024

Ilie-Lesan commented Jul 13, 2024

goodov Jul 15, 2024

Choose a reason for hiding this comment

Ilie-Lesan Jul 15, 2024 • edited Loading

Choose a reason for hiding this comment

goodov commented Jul 15, 2024

goodov commented Jul 25, 2024

goodov left a comment

Choose a reason for hiding this comment

goodov Jul 29, 2024 • edited Loading

Choose a reason for hiding this comment

goodov Jul 29, 2024

Choose a reason for hiding this comment

Ilie-Lesan Jul 29, 2024

Choose a reason for hiding this comment

goodov Jul 29, 2024

Choose a reason for hiding this comment

Ilie-Lesan commented Jul 29, 2024

goodov commented Oct 31, 2024

Ilie-Lesan commented Nov 30, 2024

Ilie-Lesan commented Jan 2, 2025

Ilie-Lesan Jul 10, 2024 •

edited

Loading

Ilie-Lesan Jul 15, 2024 •

edited

Loading

goodov Jul 29, 2024 •

edited

Loading