Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://suumo.jp/ on IOS #345

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Fix https://suumo.jp/ on IOS #345

merged 1 commit into from
Mar 2, 2020

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Mar 2, 2020

Filter is taken from easylist/easylist@04d3f7179ce7

Url we're whitelisting: https://asset01.suumo.jp/sp/js/beacon.js?id=2020022728cf47abcd

Visiting: https://suumo.jp/sp/chintai/tokyo/ek_004026540/cond/?sjoken%5B0%5D=059 wouldn't let the user go the next page at the bottom.

Affecting IOS as reported by @chkk525

@pes10k
Copy link
Collaborator

pes10k commented Mar 2, 2020

@ryanbr would it make sense to add iOS only list? Do you have a sense of how many rules are only targeting iOS?

@ryanbr
Copy link
Collaborator Author

ryanbr commented Mar 2, 2020

@pes10k Not sure if it would be needed (since only cover small / very specific circumstances). Maybe Anti-adblock (Which Brave Android also benefits), and brave://adblock requests #266 #85

Maybe we can create brave-mobile list, to cover both ios/android. and move most/if not all Anti-adblock into this list once snippet support is in Desktop Release.

From https://github.com/brave/adblock-lists/issues?utf8=%E2%9C%93&q=label%3A%22ios+specific%22

Just to detail why we have the following filters:

Some Anti-adblock filters would target ios/Android (Lack of snippet support): #85

Since IOS dosn't have brave://adblock: #266

If we're pulling/converting the changes from Easyprivacy, we could remove:
#302
#326
#276
#277
#345 (this commit)

@pes10k
Copy link
Collaborator

pes10k commented Mar 2, 2020

That all sounds good to me. I'll merge this in now, but @ryanbr can you keep that on your radar, and when the number of ios / android / mobile specific rules get to say ~50, lets do it. In the meantime, just noting which rules are targeting mobile should be good

@pes10k pes10k merged commit d0ce8ad into brave:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants