-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode version update #445
Xcode version update #445
Conversation
Co-authored-by: Jax DesMarais-Leder <[email protected]>
Co-authored-by: Jax DesMarais-Leder <[email protected]>
Co-authored-by: Jax DesMarais-Leder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SPM failure is due to this work being done off of a fork and the UI tests failure has been consistent across the last few PRs.
Should we also bump the Package.swift (here) & Podpsec (here) to the newer Swift version too? Otherwise we can't leverage new language features when building for those packages Cc: @jaxdesmarais |
Well, we aren't using Swift at all here. 🙈 But yeah I don't see why we couldn't bump those and eventually we can take advantage of those features! @stechiu do you want to bump those in this PR? |
Awesome, made the changes so I think we're good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will also want to bump this to Swift 5.9:
braintree-ios-drop-in/Package.swift
Line 1 in 07807c9
// swift-tools-version:5.7 |
…p-in into xcode-version-update
🤦♀️ I did make the change and could've sworn that I merged it in yesterday... |
Co-authored-by: Jax DesMarais-Leder <[email protected]>
…intree-ios-drop-in into xcode-version-update
Summary of changes
https://developer.apple.com/support/xcode/
Checklist
Authors