Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode version update #445

Merged
merged 12 commits into from
Mar 28, 2024
Merged

Xcode version update #445

merged 12 commits into from
Mar 28, 2024

Conversation

stechiu
Copy link
Contributor

@stechiu stechiu commented Mar 20, 2024

Summary of changes

  • Bumped Xcode version to 15.0

https://developer.apple.com/support/xcode/

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@stechiu stechiu requested a review from a team as a code owner March 20, 2024 23:22
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
stechiu and others added 5 commits March 21, 2024 12:56
Co-authored-by: Jax DesMarais-Leder <[email protected]>
Co-authored-by: Jax DesMarais-Leder <[email protected]>
Co-authored-by: Jax DesMarais-Leder <[email protected]>
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SPM failure is due to this work being done off of a fork and the UI tests failure has been consistent across the last few PRs.

@scannillo
Copy link
Contributor

scannillo commented Mar 26, 2024

Should we also bump the Package.swift (here) & Podpsec (here) to the newer Swift version too?

Otherwise we can't leverage new language features when building for those packages

Cc: @jaxdesmarais

@jaxdesmarais
Copy link
Contributor

Should we also bump the Package.swift (here) & Podpsec (here) to the newer Swift version too?

Otherwise we can't leverage new language features when building for those packages

Well, we aren't using Swift at all here. 🙈 But yeah I don't see why we couldn't bump those and eventually we can take advantage of those features! @stechiu do you want to bump those in this PR?

@stechiu
Copy link
Contributor Author

stechiu commented Mar 27, 2024

Should we also bump the Package.swift (here) & Podpsec (here) to the newer Swift version too?
Otherwise we can't leverage new language features when building for those packages

Well, we aren't using Swift at all here. 🙈 But yeah I don't see why we couldn't bump those and eventually we can take advantage of those features! @stechiu do you want to bump those in this PR?

Awesome, made the changes so I think we're good now

Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also want to bump this to Swift 5.9:

// swift-tools-version:5.7

CHANGELOG.md Outdated Show resolved Hide resolved
@stechiu
Copy link
Contributor Author

stechiu commented Mar 28, 2024

We will also want to bump this to Swift 5.9:

// swift-tools-version:5.7

🤦‍♀️ I did make the change and could've sworn that I merged it in yesterday...

Co-authored-by: Jax DesMarais-Leder <[email protected]>
@stechiu stechiu merged commit b475996 into braintree:main Mar 28, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants