Skip to content

Commit

Permalink
fixing angular install in ci pipline
Browse files Browse the repository at this point in the history
  • Loading branch information
@electron2302
electron2302 authored Dec 9, 2019
1 parent 461c56e commit 210da72
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions .drone.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,7 @@ type: docker
name: ci

steps:

#- name: "Install angular-cli"
# image: node:10
# commands:
# - "npm install -g @angular/cli"


- name: "Install dependencies"
image: node:10
commands:
Expand All @@ -20,12 +15,12 @@ steps:
failure: ignore # only until PhantomJS is working, after that, this line should be deleted !
commands:
- cd brainkeeper
- "npm install @angular/cli"
- "npm install -g @angular/cli"
- "ng test --browsers PhantomJS"

- name: "Lint"
image: node:10
commands:
- cd brainkeeper
- "npm install @angular/cli"
- "npm install -g @angular/cli"
- ng lint

3 comments on commit 210da72

@electron2302
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walli545
Hey, could you take a look at the testing, i can't get it to work, i alway get this " Use of reserved word 'class' " error and i am kinda lost

@walli545
Copy link
Member

@walli545 walli545 commented on 210da72 Dec 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@electron2302

I got it to work now with puppeteer using headless chrome. PhantomJs is not an option anymore due to them discontinuing development (see ariya/phantomjs#15344) and therefore not supporting newest JS syntax.

The current approach needs to install a lot of libraries before being able to run the tests and takes basically forever (see https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md#running-puppeteer-in-docker).
We should think abound using another base image that already includes puppeteer and headless chrome (like https://hub.docker.com/r/buildkite/puppeteer) in order to reduce run times.

The tests that fail at the moment should be fixed in the next sprint. They fail because some dependencies are not included in the auto generated tests.

@electron2302
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sooo much @walli545
And I am now already using the different image that you suggested

Please sign in to comment.