Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Sort Questions by Followed Users #691

Merged
merged 9 commits into from
Dec 16, 2024
Merged

[Backend] Sort Questions by Followed Users #691

merged 9 commits into from
Dec 16, 2024

Conversation

ozdentarikcan
Copy link
Contributor

📋 Proposed Changes

  • Questions are sorted according to the Users Followed.
  • The questions with Authors that are Followed appear higher than other questions.

Related Issue

Closes #689.

@ozdentarikcan ozdentarikcan added type: enhancement New feature or request priority: high High priority component: backend About backend labels Dec 16, 2024
@ozdentarikcan ozdentarikcan requested a review from mmtftr December 16, 2024 10:59
@ozdentarikcan ozdentarikcan self-assigned this Dec 16, 2024
mmtftr
mmtftr requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mmtftr mmtftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please never use a user id that can be changed by the user. This constitutes a severe security issue

backend/src/main/java/com/group1/programminglanguagesforum/Services/QuestionService.java Outdated Show resolved Hide resolved
@ozdentarikcan
Copy link
Contributor Author

Thanks, I get the User from UserContextService now.

@ozdentarikcan ozdentarikcan requested a review from mmtftr December 16, 2024 12:44
@ozdentarikcan ozdentarikcan requested a review from mmtftr December 16, 2024 15:28
mmtftr
mmtftr approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mmtftr mmtftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@ozdentarikcan ozdentarikcan merged commit 79eb06b into develop Dec 16, 2024
1 check passed
@ozdentarikcan ozdentarikcan mentioned this pull request Dec 16, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmtftr mmtftr mmtftr approved these changes

Assignees

@ozdentarikcan ozdentarikcan

Labels
component: backend About backend priority: high High priority type: enhancement New feature or request
Projects
None yet
Milestone
451 - Customer Milestone 3 - Final Pr...
Development

Successfully merging this pull request may close these issues.
2 participants
@ozdentarikcan @mmtftr