Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend/feature/fix tag badge routing #688

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Frontend/feature/fix tag badge routing #688

merged 3 commits into from
Dec 14, 2024

Conversation

NazireAta
Copy link
Contributor

📋 Proposed Changes

Added link to badges.

Related Issue

Closes #687

🧪 Included Tests

  • Reproduced the problem, tag badges now successfully route to tag page

@NazireAta NazireAta added type: bug Something isn't working component: frontend About frontend labels Dec 14, 2024
@NazireAta NazireAta requested a review from mmtftr December 14, 2024 20:08
@NazireAta NazireAta self-assigned this Dec 14, 2024
@NazireAta NazireAta changed the base branch from main to develop December 14, 2024 20:11
mmtftr
mmtftr approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@mmtftr mmtftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@NazireAta NazireAta merged commit 8951b26 into develop Dec 14, 2024
1 check passed
@NazireAta NazireAta deleted the frontend/feature/fix_tag_badge_routing branch December 14, 2024 20:15
@NazireAta NazireAta mentioned this pull request Dec 14, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmtftr mmtftr mmtftr approved these changes

Assignees

@NazireAta NazireAta

Labels
component: frontend About frontend type: bug Something isn't working
Projects
None yet
Milestone
451 - Customer Milestone 3 - Final Pr...
Development

Successfully merging this pull request may close these issues.

Tag Badge Link Issue
2 participants
@NazireAta @mmtftr