Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] Implement Bookmark Page #684

Merged
merged 8 commits into from
Dec 15, 2024
Merged

[Frontend] Implement Bookmark Page #684

merged 8 commits into from
Dec 15, 2024

Conversation

ozdentarikcan
Copy link
Contributor

📋 Proposed Changes

  • The bookmark page is implemented.
  • The button that navigates to bookmark page is implemented inside the user profile page.

Related Issue

Closes #594

🧪 Included Tests

  • Bookmarked questions are rendered correctly.

@ozdentarikcan ozdentarikcan added type: enhancement New feature or request priority: high High priority component: frontend About frontend labels Dec 14, 2024
@ozdentarikcan ozdentarikcan requested a review from mmtftr December 14, 2024 18:41
@ozdentarikcan ozdentarikcan self-assigned this Dec 14, 2024
@mmtftr mmtftr force-pushed the frontend/feature/594/bookmark-page branch from 6f99ae1 to 43f64b3 Compare December 14, 2024 19:00
mmtftr
mmtftr requested changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@mmtftr mmtftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the work here, I just have a couple of style and minor comments

frontend/src/routes/profile.tsx Outdated Show resolved Hide resolved
frontend/src/routes/index.tsx Outdated Show resolved Hide resolved
frontend/src/routes/bookmarked.tsx Outdated Show resolved Hide resolved
frontend/src/routes/bookmarked.test.tsx Outdated Show resolved Hide resolved
@ozdentarikcan ozdentarikcan requested a review from mmtftr December 14, 2024 19:43
@ozdentarikcan
Copy link
Contributor Author

Thanks for the feedback! I updated all the files accordingly.

mmtftr
mmtftr approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@mmtftr mmtftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good to me

@ozdentarikcan ozdentarikcan merged commit 9e0cf7a into develop Dec 15, 2024
1 check passed
@ozdentarikcan ozdentarikcan mentioned this pull request Dec 15, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmtftr mmtftr mmtftr approved these changes

Assignees

@ozdentarikcan ozdentarikcan

Labels
component: frontend About frontend priority: high High priority type: enhancement New feature or request
Projects
None yet
Milestone
451 - Customer Milestone 3 - Final Pr...
Development

Successfully merging this pull request may close these issues.
2 participants
@ozdentarikcan @mmtftr