Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Accessibility Issues #648

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

NazireAta
Copy link
Contributor

@NazireAta NazireAta commented Dec 10, 2024

📋 Proposed Changes

Guaranteed that the Accessibility score is exactly 100 for the following pages:

  • Create Question
  • Home
  • Login
  • Profile (self)
  • Profile (other user)
  • Question
  • Search
  • Signup
  • Tag

Related Issue

Closes #644

🧪 Included Tests

checked all the pages manually using Lighthouse

@NazireAta NazireAta added type: bug Something isn't working priority: high High priority component: frontend About frontend labels Dec 10, 2024
@NazireAta NazireAta requested a review from mmtftr December 10, 2024 08:19
@NazireAta NazireAta self-assigned this Dec 10, 2024
@mmtftr
Copy link
Contributor

mmtftr commented Dec 10, 2024

Please set the base to develop instead of main

@NazireAta NazireAta changed the base branch from main to develop December 10, 2024 08:20
@NazireAta NazireAta merged commit 94135ed into develop Dec 10, 2024
1 check passed
@NazireAta NazireAta deleted the frontend/feature/fix_accessibility_issues branch December 10, 2024 08:27
@NazireAta NazireAta mentioned this pull request Dec 10, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: frontend About frontend priority: high High priority type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Accessibility Issues
2 participants