Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] Implement Tag and Question References for Answer Creation #624

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

asligook
Copy link
Contributor

@asligook asligook commented Dec 6, 2024

📋 Proposed Changes

  • The custom React Markdown component will allow users to mention tags and questions while creating answers.

Related Issue

🧪 Included Tests

  • The user follows the writing format for tags : tag name, questions: [question title](# q-2)
  • The user clicks on the link and navigates to the related tag or question page.

@asligook asligook added priority: medium Medium priority component: frontend About frontend labels Dec 6, 2024
@asligook asligook requested a review from mmtftr December 6, 2024 14:41
@asligook asligook self-assigned this Dec 6, 2024
@@ -112,7 +114,18 @@ export function CreateAnswerForm({ questionId }: CreateAnswerFormProps) {

{isPreviewMode ? (
<div className="min-h-[200px] rounded-lg border border-gray-300 bg-white p-4">
<ContentWithSnippets content={content} />
Copy link
Contributor

@mmtftr mmtftr Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't add a new ReactMarkdown here, instead add the custom component to the ReactMarkdown element within ContentWithSnippets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the most confusing part, thanks for the tip! Working on it.

Copy link
Contributor

@mmtftr mmtftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good to me

@asligook
Copy link
Contributor Author

Closes #624.

@asligook asligook merged commit 613ed28 into develop Dec 11, 2024
1 check passed
@mmtftr mmtftr deleted the frontend/feature/tag-question-ref branch December 13, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: frontend About frontend priority: medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants