Backend/feature/175 get comments endpoint #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backend/src/main/java/com/group1/cuisines/controllers/RecipeController.java # backend/src/main/java/com/group1/cuisines/services/RecipeService.java
|
I tested the endpoint but encountered an infinite recursion in the response, probably caused by mappings. Let me solve the problem before merging this. |
|
@boraykasap, You need to return a CommentDto class in response to prevent recursion. You can implement like this. Also, It should not contain all details of the recipe. |
atakanyasar
reviewed
May 12, 2024
| @@ -5,7 +5,7 @@ jwt.signing.key=413F4428472B4B6250655368566D5970337336763979244226452948404D6351 | |||
| spring.application.name=cuisines | |||
| spring.datasource.url=jdbc:mysql://localhost:3306/cuisines-test?createDatabaseIfNotExist=true | |||
| spring.datasource.username=root | |||
| spring.datasource.password=admin | |||
| spring.datasource.password=adminadmin | |||
There was a problem hiding this comment.
application.properties should not change in development branch.
There was a problem hiding this comment.
Taken into account and solved
atakanyasar
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement get /recipes/{recipeId}/comments