Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: add selfhosting view toggle #62

Merged
merged 2 commits into from
Jan 1, 2025
Merged

frontend: add selfhosting view toggle #62

merged 2 commits into from
Jan 1, 2025

Conversation

l-zeuch
Copy link
Collaborator

@l-zeuch l-zeuch commented Jan 1, 2025

Implement a "selfhosting view" that optionally shows information only
relevant to or available on a selfhosted instance of YAGPDB.

Closes #25 -- see there for additional discussion.

Signed-off-by: Luca Zeuch [email protected]

Terms

@l-zeuch l-zeuch marked this pull request as draft January 1, 2025 10:48
@l-zeuch l-zeuch force-pushed the selfhosting-view branch 2 times, most recently from 8914857 to b9d1100 Compare January 1, 2025 11:45
@l-zeuch l-zeuch changed the title WIP: frontend: add selfhosting view toggle frontend: add selfhosting view toggle Jan 1, 2025
@l-zeuch l-zeuch marked this pull request as ready for review January 1, 2025 11:46
@l-zeuch
Copy link
Collaborator Author

l-zeuch commented Jan 1, 2025

Unfortunately the link render hook does not enjoy having to search for
headings within shortcodes; I'm inclined to somehow quench or ignore
those warnings, unless someone more familiar with the link renderer has
an approach to make it not complain about that situation.

assets/js/custom.js Outdated Show resolved Hide resolved
assets/js/custom.js Outdated Show resolved Hide resolved
assets/js/custom.js Outdated Show resolved Hide resolved
Preliminary commit to cater some feedback about its design and
underlying JS code; will implement actual content modification later.

Signed-off-by: Luca Zeuch <[email protected]>
@l-zeuch
Copy link
Collaborator Author

l-zeuch commented Jan 1, 2025

I have force-pushed an update; should be good now. Thanks for the review :3

@l-zeuch l-zeuch merged commit 8c07718 into master Jan 1, 2025
5 checks passed
@l-zeuch l-zeuch deleted the selfhosting-view branch January 1, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion]: Integrating Info For Self-Hosters Into Documentation
2 participants