-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/customcommands: document custom commands section #14
docs/customcommands: document custom commands section #14
Conversation
Initialise the work on documenting the Core section on the control panel. This initial page succintly summarises what's going on in this chapter and lists the subpages via the `children` shortcode. Signed-off-by: SoggySaussages <[email protected]>
Document the commands page, as well as group behaviours and configuring groups. Additionally document Custom Commands and configuration thereof. Signed-off-by: SoggySaussages <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a slight complaint about the images looking like they were grabbed from mobile. The more I think about it though, the more I think it might be fine with the amount of people asking about how to navigate the control panel via mobile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a somewhat inconsistent use of title case in your headers.
I understand that this may cause inconsistencies with the control panel
due to them being labelled in "normal" case, but I think we should stick
to title case as long as said label isn't a full sentence or something
to that extend.
I.e. "Output errors as command response" stays as-is,
but "Saving your command" should be "Saving Your Command" instead.
General note: As previously discussed in the private If you have not done that already, please remember to do so. |
add tag to delineate end of text hugo should include in the preview text in table of contents Signed-off-by: SoggySaussages <[email protected]>
Move images into same directory as the pages which reference them. See commit 9a96717 Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Document the database page with details of each column. Signed-off-by: SoggySaussages <[email protected]>
Add screenshots for this tooltip which is otherwise confusing. I think it either needs these screenshots or to be removed entirely. Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
also shift "This feature is premium only" to the top of feature's description. Signed-off-by: SoggySaussages <[email protected]>
* seach -> search * 100kB -> 100 kB Signed-off-by: Luca Zeuch <[email protected]>
I've gone ahead fixed the last two review comments myself. Thanks for the PR! |
I plan on adding the database page and proofreading everything in full, as well as manually breaking the lines at 120 characters (VSC user :p) but I'd appreciate feedback to know if I'm heading in the right direction.
For your convenience I am hosting this branch on https://yagdocsv2.vedamaharaj.ca/custom-commands.html.
Terms