docs: borg serve: recommend using a simple shell (closes #3818) #8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qyanu
force-pushed
the
3818recommendchsh-master
branch
from
fa31c2c to
5ce345e
Compare
qyanu
force-pushed
the
3818recommendchsh-master
branch
from
5ce345e to
77dbf13
Compare
) Co-authored-by: Thomas Waldmann <[email protected]>
qyanu
force-pushed
the
3818recommendchsh-master
branch
from
8b12e03 to
048ff2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #8318
As a short summary of issue 8318:
openssh executes the user's configured shell with the whole command (either remote-command or forced-command) as a single argument like so:
"$SHELL" -c "$COMMAND".This entails a larger attack surface, when a complex and feature-rich shell is configured for the user.
Because in the example configuration of a push backup server a complex and feature-rich shell is not needed, recommending the usage of a simple shell like /bin/sh will reduce the opportunity of yet-undiscovered security vulnerabilities to arise in the future.