feat: Lightbridge exit fee #33
Conversation
wsdt
commented
Apr 24, 2024
•
wsdt
commented
- Deduct static 1% fee for networks that have disabled airdrop (basically L1s / all networks aside from Boba ETH/BNB)
- Added tests
| enableExitFee && | ||
| !BobaChains[serviceChainId]?.airdropConfig?.airdropEnabled | ||
| ) { | ||
| return amount.mul(99).div(100) |
There was a problem hiding this comment.
also i think we need rounding up/down here because this is in wei?
There was a problem hiding this comment.
what do you mean with rounding up/down? @souradeep-das
There was a problem hiding this comment.
avoiding decimal places
There was a problem hiding this comment.
I think I don't understand. These are BigNumbers, as such they do not support floating point numbers and always return an integer (rounded).
Merging so that we can get a new release out, but please comment if I misunderstand something and I'll fix it in a separate PR!
Since we have a minDepositAmount on the contracts this is a scenario that should never happen. :-) |
