Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update price from CoinGecko #1367

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

boyuan-chen
Copy link
Contributor

📋 Add associated issues, tickets, docs URL here.

Overview

Describe what your Pull Request is about in a few sentences.

The on-chain price oracle is out of date. This PR uses the price oracle from CoinGecko.

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

  • Load price from CoinGecko

Testing

Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

Copy link

@jyellick jyellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM -- but

packages/boba/gas-price-oracle/src/service.ts Outdated Show resolved Hide resolved
@boyuan-chen boyuan-chen merged commit 9e8c2bf into develop Mar 15, 2024
5 of 11 checks passed
@boyuan-chen boyuan-chen deleted the use-gas-price-from-coingecko branch March 15, 2024 21:34
Copy link
Contributor

@souradeep-das souradeep-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants