tests cleanup

bobanetwork · Jul 30, 2024 · c8e2622 · c8e2622
1 parent aae9e1e
commit c8e2622
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 28 deletions.
diff --git a/contracts/src/TokenPrice.sol b/contracts/src/TokenPrice.sol
@@ -16,13 +16,6 @@ contract TokenPrice {
         helperAddr = _helperAddr;
     }
 
-    function getTest(string calldata token) public {
-        tokenPrices[token] = TokenPriceStruct({
-            price: "10",
-            timestamp: block.timestamp
-        });
-    }
-
     function fetchPrice(string calldata token) public {
         HybridAccount ha = HybridAccount(payable(helperAddr));
         string memory price;

diff --git a/contracts/test/TokenPrice.t.sol b/contracts/test/TokenPrice.t.sol
@@ -10,6 +10,7 @@ contract MockHybridAccount {
     }
 }
 
+/** @dev Unit tests */
 contract TokenPriceTest is Test {
     TokenPrice public tokenPrice;
     MockHybridAccount public mockHybridAccount;

diff --git a/contracts/test/TokenPrice.test.ts b/contracts/test/TokenPrice.test.ts
@@ -3,31 +3,35 @@ import { ethers } from "hardhat";
 import { SignerWithAddress } from "@nomiclabs/hardhat-ethers/signers";
 import { Contract } from "ethers";
 
-describe("TokenPrice", function () {
-  let tokenPrice: Contract
+/** Integration tests */
+describe("Integration tests", () => {
+  describe("TokenPrice", () => {
+    let tokenPrice: Contract
 
-  before(async () => {
-    const [owner] = await ethers.getSigners();
+    before(async () => {
+      const [owner] = await ethers.getSigners();
 
-    // Deploy the HybridAccount contract
-    const HybridAccount = await ethers.getContractFactory("HybridAccount");
-    const hybridAccount = await HybridAccount.deploy();
-    await hybridAccount.deployed();
+      // Deploy the HybridAccount contract
+      const HybridAccount = await ethers.getContractFactory("HybridAccount");
+      const hybridAccount = await HybridAccount.deploy();
+      await hybridAccount.deployed();
 
-    // Deploy the TokenPrice contract
-    const TokenPrice = await ethers.getContractFactory("TokenPrice");
-    tokenPrice = await TokenPrice.deploy(hybridAccount.address);
-    await tokenPrice.deployed();
-  })
+      // Deploy the TokenPrice contract
+      const TokenPrice = await ethers.getContractFactory("TokenPrice");
+      tokenPrice = await TokenPrice.deploy(hybridAccount.address);
+      await tokenPrice.deployed();
 
-  it("should call fetchPrice function", async function () {
+    })
 
-    // Call the fetchPrice function
-    const tx = await tokenPrice.fetchPrice("ETH");
-    await tx.wait();
+    it("should call fetchPrice function", async function () {
 
-    // Verify the price was stored correctly
-    const storedPrice = await tokenPrice.tokenPrices("ETH");
-    expect(storedPrice.price).to.equal("1234");
+      // Call the fetchPrice function
+      const tx = await tokenPrice.fetchPrice("ETH");
+      await tx.wait();
+
+      // Verify the price was stored correctly
+      const storedPrice = await tokenPrice.tokenPrices("ETH");
+      expect(storedPrice.price).to.equal("1234");
+    });
   });
-});
+})