Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qps merger #4

Merged
merged 42 commits into from
Jun 5, 2024
Merged

Qps merger #4

merged 42 commits into from
Jun 5, 2024

Conversation

bnetzi
Copy link
Owner

@bnetzi bnetzi commented Jun 5, 2024

🛑 Important:

Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!

For guidelines on how to contribute, please review the CONTRIBUTING.md document.

Purpose of this PR

Provide a clear and concise description of the changes. Explain the motivation behind these changes and link to relevant issues or discussions.

Proposed changes:

  • <Change 1>
  • <Change 2>
  • <Change 3>

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

ben-tzionlmb and others added 30 commits March 17, 2024 19:06
…-applications/spark-operator-code into queue-per-app

# Conflicts:
#	pkg/webhook/patch.go
* remove non-existent field

Signed-off-by: Aran Shavit <[email protected]>

* bump version

Signed-off-by: Aran Shavit <[email protected]>

* README

Signed-off-by: Aran Shavit <[email protected]>

---------

Signed-off-by: Aran Shavit <[email protected]>
…irrespective of image change (kubeflow#1992)

* Update workflow to publish Helm charts on chart changes, irrespective of image updates

Signed-off-by: Vara Bonthu <[email protected]>

* fixed the chart name with prefix

Signed-off-by: Vara Bonthu <[email protected]>

---------

Signed-off-by: Vara Bonthu <[email protected]>
* Add emptyDir sizeLimit support

Signed-off-by: Jacob Salway <[email protected]>

* Bump appVersion and add sizeLimit example

Signed-off-by: Jacob Salway <[email protected]>

---------

Signed-off-by: Jacob Salway <[email protected]>
* feat: add support for service labels on driver-svc

Signed-off-by: Cian Gallagher <[email protected]>

* docs: update helm docs

Signed-off-by: Cian Gallagher <[email protected]>

* fix: undo changes to api-docs

Signed-off-by: Cian Gallagher <[email protected]>

* docs: update api-docs

Signed-off-by: Cian Gallagher <[email protected]>

* fix: update appVersion

Signed-off-by: Cian Gallagher <[email protected]>

* ci: remove step to check api change

Signed-off-by: Cian Gallagher <[email protected]>

* docs: update helm-docs

Signed-off-by: Cian Gallagher <[email protected]>

* docs: update helm-docs

Signed-off-by: Cian Gallagher <[email protected]>

* fix: update app version

Signed-off-by: Cian Gallagher <[email protected]>

* docs: update helm docs

Signed-off-by: Cian Gallagher <[email protected]>

---------

Signed-off-by: Cian Gallagher <[email protected]>
Signed-off-by: Peter Jablonski <[email protected]>
…1 even when minExecutors is set to 0 (kubeflow#1979)

Signed-off-by: Peter McClonski <[email protected]>
…tions/spark-operator-code into list-map-mutex

# Conflicts:
#	pkg/controller/sparkapplication/controller.go
…eflow#1998)

* Add driverIngressOptions in SparkApplication CRD

Signed-off-by: Bo (AIML) Yang <[email protected]>

* Update chart version to 1.3.0

Signed-off-by: Bo (AIML) Yang <[email protected]>

* Update helm chart README

Signed-off-by: Bo (AIML) Yang <[email protected]>

* Fix make detect-crds-drift

Signed-off-by: Bo (AIML) Yang <[email protected]>

* Update api-docs.md

Signed-off-by: Bo (AIML) Yang <[email protected]>

---------

Signed-off-by: Bo (AIML) Yang <[email protected]>
ben-tzionlmb and others added 12 commits May 22, 2024 17:11
Add [Inter&Co](https://inter.co/) to who is using the SparkOperator.

Signed-off-by: Yuri Niitsuma <[email protected]>
…iners CRDs (kubeflow#2022)

* Add restartPolicy field to SparkApplication CRDs

Signed-off-by: Mark Schroering <[email protected]>

* Add restartPolicy field to SparkApplication CRDs

Signed-off-by: Mark Schroering <[email protected]>

* Add restartPolicy field to SparkApplication CRDs

Signed-off-by: Mark Schroering <[email protected]>

---------

Signed-off-by: Mark Schroering <[email protected]>
…rger

# Conflicts:
#	Dockerfile
#	main.go
#	pkg/controller/sparkapplication/controller.go
@bnetzi
Copy link
Owner Author

bnetzi commented Jun 5, 2024

Resolved conflicts, add Qpsand burst parameters, and list of maps of queues (instead of one map)

@bnetzi bnetzi merged commit dcae610 into master Jun 5, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.