Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add async buffer #69

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Conversation

will-2012
Copy link
Contributor

@will-2012 will-2012 commented Mar 8, 2024

Description

Add async buffer to improve performance in the tire commit phase of the path-base scheme.

Rationale

N/A.

Example

N/A.

Changes

Notable changes:

  • path/database.

@github-actions github-actions bot requested review from owen-reorg and redhdx March 8, 2024 08:33
@will-2012 will-2012 changed the title Feat: add async buffer feat: add async buffer Mar 8, 2024
@will-2012 will-2012 force-pushed the feat-async-buffer branch from 567ab1d to 1735ea9 Compare March 8, 2024 08:56
@krish-nr
Copy link
Contributor

some UT related to disklayer not passed, need to find the root cause

@will-2012
Copy link
Contributor Author

will-2012 commented Mar 12, 2024

some UT related to disklayer not passed, need to find the root cause

Fixed, path-base rewind maybe use trie-head as disk-root for rewinding speed(hash-base use snapshot root as disk-root).

krish-nr
krish-nr previously approved these changes Mar 12, 2024
Copy link
Contributor

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krish-nr krish-nr merged commit 6c6833a into bnb-chain:develop Mar 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants