Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insert error stage to rpc error in OpSealPayload engine api #255

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

bnoieh
Copy link
Contributor

@bnoieh bnoieh commented Jan 16, 2025

Description

This pr fix error return of engine_opSealPaylaod api, related fix to op-node is bnb-chain/opbnb#259

Rationale

The error return of original engine_api is chaos and easy lead to bug, the new engine_opSealPayload api followed the original part, and unfortunately triggered bug, which will cause chain stuck if force kill

Example

n/a

Changes

insert error stage to rpc error in OpSealPayload engine api

owen-reorg
owen-reorg previously approved these changes Jan 16, 2025
andyzhang2023
andyzhang2023 previously approved these changes Jan 17, 2025
Copy link
Contributor

@andyzhang2023 andyzhang2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnoieh bnoieh dismissed stale reviews from andyzhang2023 and owen-reorg via cf82d72 January 17, 2025 04:27
Copy link
Contributor

@andyzhang2023 andyzhang2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit 41f0426 into bnb-chain:develop Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants