pevm: fallback to sequencial processor when the TxDAG is too deep #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependencies is too deep
sunny2022da
reviewed
Jan 10, 2025
cmd/utils/flags.go
Outdated
| ParallelTxDATMaxDepthRatioFlag = &cli.Float64Flag{ | ||
| Name: "parallel.txdag-max-depth-ratio", | ||
| Usage: "A ratio to decide whether or not to execute transactions in parallel, it will fallback to sequencial processor if the depth is larger than this value (default = 1.0)", | ||
| Value: 1.0, |
There was a problem hiding this comment.
may be we can set the default value to 0.9? it seems 1.0 means there is almost 1 tx in every level. so PEVM is expected to degrade the performance in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new option is added to improve the performance when the TxDAG contains a deep dependency chain. The performance might become poor when many transactions depend on each other in a block. So we add a threshold option under which the parallel EVM will be enabled, otherwise, the block will be processed by the original EVM in sequential.
Example
Add flag
--parallel.txdag-max-depth-ratioto enable this feature. Default to be not enabled.