Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disallow copy an object is being updated #587

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix: disallow copy an object is being updated #587

merged 2 commits into from
Mar 11, 2024

Conversation

alexgao001
Copy link
Collaborator

@alexgao001 alexgao001 commented Mar 8, 2024 •
edited
Loading

Description

  1. disallow copy an object is being updated
  2. an object might be set to OBJECT_STATUS_DISCONTINUED, should not allow sealing on it.

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Potential Impacts

  • add potential impacts for other components here
  • ...

unclezoro
unclezoro previously approved these changes Mar 8, 2024
View reviewed changes
@alexgao001 alexgao001 added the r4r label Mar 11, 2024
@keefel keefel added this pull request to the merge queue Mar 11, 2024
Merged via the queue into bnb-chain:master with commit 164ef7e Mar 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forcodedancing forcodedancing forcodedancing approved these changes

@keefel keefel keefel approved these changes

@unclezoro unclezoro unclezoro left review comments

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexgao001 @unclezoro @forcodedancing @keefel