fix: seal object validate if secondary SP in_service #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgao001
force-pushed
the
fix-seal-check-spstatus
branch
from
e837c50 to
9dd6e2f
Compare
alexgao001
force-pushed
the
fix-seal-check-spstatus
branch
from
9dd6e2f to
4470045
Compare
unclezoro
previously approved these changes
Jan 15, 2024
unclezoro
approved these changes
Jan 15, 2024
keefel
approved these changes
Jan 15, 2024
unclezoro
requested changes
Jan 15, 2024
|
hold on first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
seal object validate if secondary SP in_service, in case that SP is exiting but still need to severs as a secondary SP.
Rationale
SP not in_service should not serve users new object requests.
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts