New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change logic of resource name length check #560

Merged

pythonberg1997 merged 10 commits into bnb-chain:develop from pythonberg1997:develop

Jan 22, 2024

Contributor

pythonberg1997 commented Jan 12, 2024

Description

This pr is to change the resource name length limit from bytes length to character length

Changes

Notable changes:

change the resource name length limit from bytes length to character length

Potential Impacts

related check in sdk

pythonberg1997 added 7 commits

January 12, 2024 16:42


          feat: change logic of resource name length check

487f797


          fix: CI errors

cf8a8b9


          fix: CI errors

a0dfbc2


          fix: unit test errors

4015cd5


          fix: unit test errors

0d2aa2f


          fix: unit test errors

d177d18


          fix: unit test errors

7f0e4e3

unclezoro reviewed

View reviewed changes

x/challenge/types/message_submit.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/storage/types/crosschain.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/storage/types/message.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/storage/types/message.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

x/storage/types/message.go Outdated Show resolved Hide resolved

pythonberg1997 added 2 commits

January 19, 2024 15:47


          fix review comments

bc39507


          fix test cases

73b5486

unclezoro reviewed

View reviewed changes

go.mod Outdated

    
            @@ -180,7 +180,7 @@ replace (
          
              	github.com/cometbft/cometbft => github.com/bnb-chain/greenfield-cometbft v1.1.0

              	github.com/cometbft/cometbft-db => github.com/bnb-chain/greenfield-cometbft-db v0.8.1-alpha.1

              	github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23/go v0.8.0

              	github.com/cosmos/cosmos-sdk => github.com/bnb-chain/greenfield-cosmos-sdk v1.2.2-0.20240102032738-3661d43faf8f

              	github.com/cosmos/cosmos-sdk => github.com/Pythonberg1997/greenfield-cosmos-sdk v0.0.0-20240112053628-9e3d8de9d89e

Collaborator

unclezoro Jan 22, 2024 •

edited

Loading

Fix the dependency


          fix review comments

yutianwu approved these changes

View reviewed changes

unclezoro approved these changes

View reviewed changes

pythonberg1997 added this pull request to the merge queue

Merged via the queue into bnb-chain:develop with commit eb94297

5 checks passed

This was referenced Jan 23, 2024

doc: add change log for v1.4.0 #566

Merged

release: prepare for release v1.4.0 #567

Merged

pythonberg1997 added a commit to pythonberg1997/greenfield that referenced this pull request


          Revert "feat: change logic of resource name length check (bnb-chain#560…

5864c2b

…)"

This reverts commit eb94297

github-merge-queue bot pushed a commit that referenced this pull request


          fix: revert the modifications to resource naming rules (#568)

781b351

* Revert "feat: change logic of resource name length check (#560)"

This reverts commit eb94297

* chore: update go.mod and some error msgs

unclezoro mentioned this pull request

fix: revert the modifications to resource naming rules (#568) #569

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet