fix: update not found bucket #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryTong65
force-pushed
the
fix-not-found-bucket
branch
from
578bc2f to
a669592
Compare
mliu233
approved these changes
Jan 14, 2025
annielz
approved these changes
Jan 14, 2025
clydemeng
approved these changes
Jan 14, 2025
ruojunm
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BucketReadQuota response code should be 404 rather than 500
Rationale
{"t":"2025-01-10T15:51:51.731Z","l":"error","caller":"gater/bucket_handler.go:52","msg":"failed to get bucket info from consensus","bucket_name":"ceshi","error":"rpc error: code = Unknown desc = No such bucket: unknown request"},
Example
N/A
Changes
Notable changes:
N/A
Potential Impacts
N/A