fix: ListObjectPoliciesResponse unmarshal failed #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruojunm
reviewed
Nov 28, 2023
| @@ -1339,7 +1339,7 @@ func (c *Client) ListObjectPolicies(ctx context.Context, objectName, bucketName | |||
|
|
|||
| policies := types.ListObjectPoliciesResponse{} | |||
| bufStr := buf.String() | |||
| err = xml.Unmarshal([]byte(bufStr), &policies.Policies) | |||
There was a problem hiding this comment.
Please also add more details in the function doc for actionType parameters
There was a problem hiding this comment.
Please also add an e2e test on this API.
|
Please submit to master |
BarryTong65
force-pushed
the
fix-list-policies
branch
from
736fe1b to
5ddce4e
Compare
BarryTong65
force-pushed
the
fix-list-policies
branch
from
5ddce4e to
452b913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix ListObjectPoliciesResponse unmarshal failed bug
Rationale
Example
N/A
Changes
Notable changes: