Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/tracers: fix call nil OnSystemTxFixIntrinsicGas #2851

Merged
merged 1 commit into from
Jan 13, 2025
Merged

eth/tracers: fix call nil OnSystemTxFixIntrinsicGas #2851

merged 1 commit into from
Jan 13, 2025

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Jan 13, 2025 •
edited
Loading

Description

eth/tracers: fix call nil OnSystemTxFixIntrinsicGas

Rationale

  1. FlatCallTracer.OnSystemTxFixIntrinsicGas=CallTracer.OnSystemTxFixIntrinsicGas
  2. ensure OnSystemTxFixIntrinsicGas not equal to nil before call it
  3. remove useless empty func OnSystemTxFixIntrinsicGas in noopTracer

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as ready for review January 13, 2025 03:30
@zzzckck zzzckck merged commit d41d601 into bnb-chain:develop Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzckck zzzckck zzzckck approved these changes

@zlacfzy zlacfzy zlacfzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buddh0 @zlacfzy @zzzckck