Deduplication #35
Merged
Deduplication #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De-duplicates the model and transcribers so there's only ever one set of classes for those, using proper versioning to deal with revision-specific differences. This refactoring quite literally halved the lines-of-code in RSProx, and that's with just 4 revisions. Over time it would've become an unmaintainable mess, especially for anyone wanting to do changes in the transcribers.
The decoder remains the only thing that is now per-revision. In the future, we could potentially look into de-duplicating the @consistent classes, but this has another problem that needs to be solved on-top of it to do such a refactoring. For now, this is more than good enough.