Login response handler validation rework #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the GameLoginResponseHandler#writeSuccessfulResponse function to return a non-nullable Session.
The old implementation performed certain checks in the writeSuccessfulResponse functions, which meant it could fail and return null. This however lead to some annoying server-side code, as servers had to allocate a slot in the world for the player, try to send it to the client, then continue on normally if it succeeded, and de-allocate if it failed.
The client type check has been migrated to occur during login block decoding - if it fails, the login block itself will not even be decoded (no RSA-decrypting etc), actually improving one potential attack vector.
The activity check has been removed as it happens in plenty of situations after it, and the connection limit has been migrated to its own function, meaning servers will have to implement it themselves now.