Fix/info packets #29
Merged
Fix/info packets #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a potential issue where servers might end up deallocating and reallocating the same index player info object on the same cycle. While typically fine, if the previous player and the new player are in the same rough area, any observers of them might think the player shouldn't receive any updates. This could result in visual glitching.
This fixes a potential issue where servers might end up deallocating and reallocating the same index worldentity info object on the same cycle. Same concept as the commit above this for player info, and the one from a few days ago for npc info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes potential issues where servers might deallocate and reallocate the same index player or worldentity info on the same game cycle. This would result in any players previously observing it not acknowledging that the entity underneath an avatar was completely swapped out, and could result in visual artefacting. This is typically only possible if servers do not use the round-robin index allocation system, but it is technically also possible to happen even with it, although in practice never should.