Type hints #866
Merged
Type hints #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
approved these changes
Jan 27, 2025
danielballan
force-pushed
the
type-hints
branch
from
47a6e24 to
c7fa735
Compare
danielballan
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is currently based on top of #856, when that change has been merged the changes will be a little clearer.
Replaces the use of the Pydantic BaseSettings in type hints with the tiled Settings class- while it is an instance of BaseSettings, it's much clearer what we're expecting and passing.
Replaces lru_cache with cache- where it was being used all take 0 arguments, and so the hashing of arguments and evicting of old values makes lru_cache less efficient.
Checklist