Revert "Change Android's MainActivity launchMode to singleTop" #4397
Conversation
This reverts commit 65ad16e.
|
Your Render PR Server URL is https://social-app-pr-4397.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpgvi1mct0pc73ac5g3g. |
| with: | ||
| path: most-recent-testflight-commit.txt | ||
| key: most-recent-testflight-commit | ||
|
|
||
| - name: ✏️ Write commit hash to cache | ||
| if: ${{ inputs.channel != 'testflight' && inputs.channel != 'production' }} | ||
| if: ${{ inputs.channel == 'testflight' }} |
There was a problem hiding this comment.
we don't need to revert this part right
|
|
Hey @haileyok , sorry to revive this - I was wondering whether you tried the solution provided here? (which would apparently support both cases) expo/expo#29153 (comment) This seems to be a known issue in react native apps, spanning functionalities such as deep linking, android webviews and 3d payments. References: expo/expo#29153 |
|
Feel free to send a PR and we can have a look. Please include note on testing against past regressions this change has caused. |
Reverts #4255
Why
When using share intents, this change introduces a problem where multiple instances of the app are opened. This is pretty risky in regards to file system writes or session management. Let's revert.
Reverting does re-introduce the problem found here: #4212. We should investigate this possibly through the
expo-web-browserlibrary itself.Test Plan
Build after this revert, then open the app through a share intent (for example, through the Photos app). Multiple process shouldn't be open.