Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add new typedefs from ozone api changes #897

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

foysalit
Copy link
Contributor

@foysalit foysalit commented Jan 3, 2025

No description provided.

Copy link
Collaborator

@bnewbold bnewbold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We really will need to update how codegen works for those huge parameter lists; they should be structs which means nil will be used by default and we don't need to update a bunch of service/command code every time. that might not happen for a bit though.

@bnewbold bnewbold merged commit 2314a61 into main Jan 6, 2025
8 checks passed
@bnewbold bnewbold deleted the foysal/ozone-api-changes branch January 6, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants