feat(cmd/goat): allow specifying authFactorToken #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would close: #787 |
bnewbold
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
generally looks good. left some style nits (i'm personally opinionated about this particular tool/codebase).
there is a potential annoying case where the session times out, so the tool tries to refresh using username/password, and it fails b/c a token is resolved. it would in theory be nice to have a more specific error message/code about that, but it is probably rare enough to not block merging this improvement for now.
thanks for the contribution! a few folks have hit this and I should have been less lazy about implementing it from the start.
yeah I'm going to make it consistent
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports using goat account login with email 2fa enabled so that users do not need to first disable 2fa to then get an email token anyways to obtain plc signing tokens.