Lexicon resolution #792
Open
Lexicon resolution #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewbold
force-pushed
the
bnewbold/lex-res
branch
from
d60f92f to
12f4572
Compare
bnewbold
force-pushed
the
bnewbold/lex-res
branch
from
b50b014 to
e0ffe1c
Compare
|
This is ready for review/merge |
Will add this to 'goat' instead
bnewbold
force-pushed
the
bnewbold/lex-res
branch
from
e0ffe1c to
6ac44d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
ResolveNSIDmethod toidentity.BaseDirectory. I think keeping DNS TXT resolution stuff together in the same package makes sense, even if this is a "lexicon" thing, not really an "identity" thing. Could consider renaming that method toResolveLexiconNSIDor similar, to clarify it is about NSIDs in the context of Lexicons, not "NSIDs in general" (though they are currently only defined in terms of Lexicons).Adds a new
ResolvingCatalogimplementation of thelexicon.Cataloginterface, which does resolution from the live network and adds to a local cache. Alsolexicon.ResolveLexiconDatalow-level helper which goes from NSID to Lexicon record data.