Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to skip big shards during compaction #380

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

whyrusleeping
Copy link
Collaborator

No description provided.

@whyrusleeping
Copy link
Collaborator Author

if a shard is 'big enough', dont bother compacting it if we just want to go fast.

This will result in some data not getting cleaned up that should, but we already have that as a problem, and we need to implement a 'full clean compaction' step anyways.

carstore/bs.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@ericvolp12 ericvolp12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whyrusleeping whyrusleeping merged commit a2a51ba into main Oct 10, 2023
6 checks passed
@whyrusleeping whyrusleeping deleted the feat/compact-skip-big-shards branch October 10, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants