add sub_option type & sname/fname to config #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We likely need a way to introduce options that have sub-options or "encapsulated options" into the config. Option 43 comes to mind. We support
hex
decoding, but it is pretty cumbersome to read/write especially in the presence of encapsulated options.With change, this block of options
will be decoded into (it's a hashmap so the order is not consistent)
I've opened an issue in the protocol repo: bluecatengineering/dhcproto#45 so that we can track supporting encapsulated options better there also. To make
VendorExtensions
type really usable inside dora we likely need a way to pull out specific sub-options.I took the opportunity to add
sname
andfname
to the config also. These can now be set withserver_name
andfile_name
and will be put in the respective header fields.