Move implementation of DHCPv4 options into a macro #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a proc-macro for defining DHCPv4 options as discussed in #43 , making it easier to add more options and keeping the definitions of
DhcpOption
andOptionCode
on a single line.I tried keeping the macro itself relatively straightforward using simple string manipulation. There's probably room for improvement but if so, hopefully this can serve as a good starting point.
Things to note:
XDisplayManager
.BulkLeaseQuery*
items ofDhcpOption
were prefixed withBulkLeaseQuery
but they were not prefixed inOptionCode
(i.e.DhcpOption::BulkLeaseQueryStatusCode
mapped toOptionCode::StatusCode
), this macro prefixes both of them withBulkLeaseQuery
, in line with all the other options and keep the macro simple. Technically, the RFC refers to "Bulk leasequeries" so perhaps it should beBulkLeasequery
with theQ
in lowercase.ClasslessStaticRoute
.